Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Stats page uses Twig #3807

Merged
merged 3 commits into from Jun 11, 2019
Merged

[Refactor] Stats page uses Twig #3807

merged 3 commits into from Jun 11, 2019

Conversation

xprilion
Copy link
Contributor

@xprilion xprilion commented Jun 6, 2019

Please check if the PR fulfills these requirements:

What is the current behavior?

Closes #3806

What is the new behavior?

The following Discussion Forum view now uses Twig-

statPage

Other information?

Is this a breaking change? - None discovered yet.
How did you test - Proper working checked manually and by inspecting difference in HTML rendered before and after Twig template.

@xprilion xprilion changed the title State page uses Twig [Refactor] State page uses Twig Jun 6, 2019
@xprilion xprilion changed the title [Refactor] State page uses Twig [Refactor] Stats page uses Twig Jun 6, 2019
@andrewaikens87
Copy link
Contributor

Please resolve merge conflicts.

@xprilion
Copy link
Contributor Author

@andrewaikens87 done!

Copy link
Contributor

@andrewaikens87 andrewaikens87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended. Thanks!

@bmcutler bmcutler merged commit 559e2d1 into master Jun 11, 2019
@bmcutler bmcutler deleted the forum_view_refactor_5 branch June 11, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Twig engine for StatPage in Discussion Forum
3 participants