Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:Autograding] Add Sequence Diagrams for Networked Gradeables #4070

Merged
merged 8 commits into from Jul 24, 2019

Conversation

emaicus
Copy link
Contributor

@emaicus emaicus commented Jul 12, 2019

Should not be merged until mermaid-js/mermaid#847 is addressed.

Adds an initial (rough) version of sequence diagrams for visualization of networked gradeables.
Visualization will be cleaned up per #3968

@MasterOdin
Copy link
Member

MasterOdin commented Jul 12, 2019

What do the generated diagrams look like and how can they be interacted with?

@emaicus
Copy link
Contributor Author

emaicus commented Jul 15, 2019

This is an early example of a diagram produced by this PR. An example planned interaction is the ability to mouse over a message to see its contents in cases where message content is overlong.

sequence_diagram

@bmcutler bmcutler changed the title Add Sequence Diagrams for Networked Gradeables [CAUTION:SECURITY][Feature:Autograding] Add Sequence Diagrams for Networked Gradeables Jul 15, 2019
@MasterOdin
Copy link
Member

It looks like they've released a new version with a stricter security model which prevents XSS, but at the cost of not having any allowed click action.

@bmcutler bmcutler changed the title [CAUTION:SECURITY][Feature:Autograding] Add Sequence Diagrams for Networked Gradeables [Feature:Autograding] Add Sequence Diagrams for Networked Gradeables Jul 24, 2019
@bmcutler bmcutler merged commit 3fb5f26 into master Jul 24, 2019
@bmcutler bmcutler deleted the sequence_diagrams branch July 29, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants