Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix:InstructorUI] Excused absence extensions won't submit #5470

Merged
merged 4 commits into from Jun 7, 2020
Merged

[Bugfix:InstructorUI] Excused absence extensions won't submit #5470

merged 4 commits into from Jun 7, 2020

Conversation

mukul-kmr-jha
Copy link
Contributor

Please check if the PR fulfills these requirements:

  • The PR title and message follows our guidelines
  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

What is the current behavior?

Broken Extensions page

What is the new behavior?

Fixes #5466

Other information?

@mukul-kmr-jha mukul-kmr-jha changed the title fix: broken extension form [Bugfix:InstructorUI] Excused absence extensions won't submit Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020 •
edited

Codecov Report

Merging #5470 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5470   +/-   ##
=========================================
  Coverage     20.88%   20.88%           
  Complexity     5990     5990           
=========================================
  Files           150      150           
  Lines         19431    19431           
=========================================
  Hits           4059     4059           
  Misses        15372    15372
Flag Coverage Δ Complexity Δ
#autograder 10.66% <ø> (ø) 0.00 <ø> (ø)
#migrator 100.00% <ø> (ø) 0.00 <ø> (ø)
#php 20.56% <ø> (ø) 5990.00 <ø> (ø)
#python_submitty_utils 3.04% <ø> (ø) 0.00 <ø> (ø)

MasterOdin
MasterOdin approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the break from #5439.

@bmcutler bmcutler merged commit b1916b9 into master Jun 7, 2020
@bmcutler bmcutler deleted the issue_5466_excused_absence branch June 7, 2020 19:20
marwanatef2 pushed a commit that referenced this pull request Jun 15, 2020
@mukul-kmr-jha @bmcutler @marwanatef2
[Bugfix:InstructorUI] Excused absence submit (#5470)
05c1397 
* fix: broken extension form

* fix: onchange event not attached

Co-authored-by: Barb Cutler <bmcutler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excused absence extensions won't submit
3 participants
@mukul-kmr-jha @MasterOdin @bmcutler