Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:TAGrading] websockets for checkpoint & numeric #5829

Merged
merged 4 commits into from Aug 27, 2020

Conversation

marwanatef2
Copy link
Contributor

@marwanatef2 marwanatef2 commented Aug 16, 2020

Please check if the PR fulfills these requirements:

  • The PR title and message follows our guidelines
  • Tests for the changes have been added/updated (if possible)

What is the current behavior?

Simple grading (checkpoints / numeric) is accessed by multiple graders simultaneously but doesn't refresh upon changes so graders can't see the latest page updates.

What is the new behavior?

Integrating websockets in simple grading will allow changes to any checkpoint/numeric-input to take place concurrently on all open graders pages (windows) so they can see the latest updates in real time.

@marwanatef2 marwanatef2 marked this pull request as draft August 16, 2020 03:34
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #5829 into master will decrease coverage by 1.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5829      +/-   ##
============================================
- Coverage     22.53%   20.55%   -1.98%     
- Complexity     6199     6914     +715     
============================================
  Files           157      157              
  Lines         20281    22384    +2103     
============================================
+ Hits           4570     4602      +32     
- Misses        15711    17782    +2071     
Flag Coverage Δ Complexity Δ
#autograder 9.72% <ø> (ø) 0.00 <ø> (ø)
#migrator 99.10% <ø> (ø) 0.00 <ø> (ø)
#php 19.48% <ø> (-2.09%) 6914.00 <ø> (+715.00) ⬇️
#python_submitty_utils 82.32% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@marwanatef2 marwanatef2 changed the title [Feature: TAGrading] Sockets in checkpoint grading. [Feature: TAGrading] Sockets in simple grading. Aug 16, 2020
@marwanatef2 marwanatef2 marked this pull request as ready for review August 16, 2020 19:39
@bmcutler bmcutler changed the title [Feature: TAGrading] Sockets in simple grading. [Feature:TAGrading] websockets for checkpoint & numeric gradeables Aug 20, 2020
@bmcutler bmcutler changed the title [Feature:TAGrading] websockets for checkpoint & numeric gradeables [Feature:TAGrading] websockets for checkpoint & numeric Aug 20, 2020
Copy link
Contributor

@jchulton jchulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working, just the question above.

site/app/controllers/grading/SimpleGraderController.php Outdated Show resolved Hide resolved
@bmcutler bmcutler merged commit 5c26d1b into master Aug 27, 2020
@bmcutler bmcutler deleted the sockets-checkpoints branch August 27, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants