Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix:System] Update Docker Hub API to v2 #8517

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

cjreed121
Copy link
Member

What is the current behavior?

We rely on the Docker Hub API version 1 to check if an image is valid. The API has been marked as deprecated and thus does not work anymore.

What is the new behavior?

The Docker interface page uses Docker Hub API version 2 now.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #8517 (69a284f) into main (0e89415) will decrease coverage by 0.49%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #8517      +/-   ##
============================================
- Coverage     22.19%   21.70%   -0.50%     
- Complexity     7674     8473     +799     
============================================
  Files           205      205              
  Lines         24186    26075    +1889     
  Branches         70       70              
============================================
+ Hits           5369     5660     +291     
- Misses        18749    20347    +1598     
  Partials         68       68              
Flag Coverage Δ
autograder 19.22% <ø> (ø)
js 28.47% <ø> (ø)
migrator 99.11% <ø> (ø)
php 20.11% <0.00%> (-0.42%) ⬇️
python_submitty_utils 71.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bmcutler bmcutler merged commit b256a6e into main Oct 18, 2022
@bmcutler bmcutler deleted the dockerhub_api_update branch October 18, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants