Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:Developer] Integrate Cypress Cloud #9517

Merged
merged 24 commits into from Aug 8, 2023
Merged

[Feature:Developer] Integrate Cypress Cloud #9517

merged 24 commits into from Aug 8, 2023

Conversation

IDzyre
Copy link
Contributor

@IDzyre IDzyre commented Jul 11, 2023

What is the current behavior?

Currently we just use the testing component of cypress.

What is the new behavior?

This will add the setup to have cypress link with cypress cloud, which will allow for easier parallelization, and it shows recordings of the tests in the cloud.

Other information?

The open source license allows for 100,000 runs (specific it('', ()=>{}) functions, not spec files) per month, so this is the testing period to see if this is enough, if not, it may be better to manually parallelize the tests and use cloud as a different feature, to see why cypress is failing in CI and not locally, but we will see. I have also communicated with some people at cypress, and they indicated that we may be able to get more runs, but I haven't communicated more about that.

This information is old. We now have an OSS cypress cloud 'organization', which allows for unlimited runs, not 100,000/month.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #9517 (edc452f) into main (8e6731f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #9517   +/-   ##
=========================================
  Coverage     23.20%   23.20%           
  Complexity     8176     8176           
=========================================
  Files           226      226           
  Lines         29210    29210           
  Branches         73       73           
=========================================
  Hits           6778     6778           
  Misses        22362    22362           
  Partials         70       70           
Flag Coverage Δ
autograder 22.08% <ø> (ø)
js 27.51% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.08% <ø> (ø)
python_submitty_utils 71.65% <ø> (ø)
submitty_daemon_jobs 91.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@IDzyre IDzyre marked this pull request as draft July 11, 2023 20:16
@IDzyre IDzyre self-assigned this Jul 12, 2023
@IDzyre IDzyre marked this pull request as ready for review July 13, 2023 00:13
@IDzyre IDzyre requested a review from bmcutler July 13, 2023 00:13
Copy link
Member

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress Cloud looks interesting, but I believe that 100,000/month test runs is not enough to meet our demand at peak times. I need to take a deeper look later, but these changes seem to be heading down the right path.

.yamllint Outdated Show resolved Hide resolved
@IDzyre IDzyre marked this pull request as draft July 13, 2023 19:10
@IDzyre
Copy link
Contributor Author

IDzyre commented Jul 13, 2023

This should be merged after (if) Submitty gets approved for an open source license, because apparently its different if you try to record, and don't have a valid key, and if you try and record, and don't have any runs left.

If you don't have any tests left, it doesn't run the cypress tests, a critical flaw that I am looking into.

@IDzyre IDzyre marked this pull request as ready for review July 13, 2023 21:31
@bmcutler
Copy link
Member

bmcutler commented Aug 4, 2023

@IDzyre please resolve merge conflicts

@bmcutler bmcutler merged commit 33e6aa7 into main Aug 8, 2023
18 checks passed
@bmcutler bmcutler deleted the setup_cloud branch August 8, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants