-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing:Developer] Manual parallelizing in Github Actions #9737
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9737 +/- ##
=========================================
Coverage 23.25% 23.25%
Complexity 8232 8232
=========================================
Files 227 227
Lines 29362 29362
Branches 73 73
=========================================
Hits 6828 6828
Misses 22464 22464
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try using the github matrix to get rid of doing similar operations
ex:
Cypress-Test:
...
strategy:
matrix:
containers: ["gradeable","admin","UI",etc...]
...
...
spec: cypress/e2e/${{matrix.containers}}/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem reasonable to me. I do worry about needing to rebalance the sets of tests occasionally, but that's certainly manageable, and better than the alternative of just running all of the tests sequentially.
Is there any parallelization you can do in one or more of the test sets? We'd have to make sure none of the tests potentially interfere with one another and the benefits of parallelization would be hampered by the limited resources available on the CI runners, but it may reduce the time slightly at least.
I think its probably possible, but to make the CI run more smoothly as it is, I think that can be a future PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this!
Please check if the PR fulfills these requirements:
What is the current behavior?
Currently, Cypress Cloud parallelizes the runs, however this only works for Submitty members, not external contributors. It also has a limit of 100,000 different test runs (Specific
It('should test...', ()=>{});
runs, not spec files or describe instances). With increasing development, and the creation of new spec files that add to the tests, this will most likely not be enought.What is the new behavior?
The runs are now split up into five different categories manually, and Cypress Cloud has been removed from CI: