Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarmosetUBER is initialized too late #455

Merged
merged 1 commit into from
Sep 4, 2023
Merged

MarmosetUBER is initialized too late #455

merged 1 commit into from
Sep 4, 2023

Conversation

Metious
Copy link
Member

@Metious Metious commented Sep 1, 2023

Changes made in this pull request

  • Fixed an issue where the MarmosetUBER is initialized quite a bit late in the stack, resulting in possible race conditions.

I've tested this both in SN1 and BZ and it's working as expected.

Special thanks to UWE, especially Artyom for their insights and assistance in making this fix a possibility.

@Metious Metious self-assigned this Sep 1, 2023
@LeeTwentyThree
Copy link
Member

Why is WaitForCompletion even legal? Either way, nice, glad we could get this sorted out.

@LeeTwentyThree
Copy link
Member

Works as intended

@LeeTwentyThree LeeTwentyThree merged commit 607f513 into SubnauticaModding:master Sep 4, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeeTwentyThree LeeTwentyThree Awaiting requested review from LeeTwentyThree

Assignees

@Metious Metious

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Metious @LeeTwentyThree