ScanningGadget & KnownTech handling #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olete The previous one was overriding the PDA scanner entry for the requirement tech type, which is against the rules of gadgets rules and very confusing.
|
The |
Fixed a bug where calling the `RemoveAllCurrentAnalysisTechEntry` would also remove the unlock for the target's analysis tech entry, resulting in unexpected behavior.
MrPurple6411
requested changes
Oct 3, 2023
We now call the original `KnownTech.Initialize` method to ensure mods that patch the method don't get unnoticed upon repatching.
MrPurple6411
approved these changes
Oct 13, 2023
Since buildables are never registered to a crafting tree, Nautilus always logs a warning for that interpreting it as a mistake, when in reality it isn't.
MrPurple6411
approved these changes
Oct 24, 2023
| } | ||
| else if (!prefab.TryGetGadget(out ScanningGadget scanningGadget) || !scanningGadget.IsBuildable) | ||
| { | ||
| InternalLogger.Log($"Prefab '{prefab.Info.ClassID}' was not automatically registered into a crafting tree."); |
There was a problem hiding this comment.
Think we could make this Debug log instead?
There was a problem hiding this comment.
I think marking that as a debug log will make it easy to miss because a craftable item without a crafting tree that isn't a buildable is alarming and it's safer to assume that the developer missed something. In fact, I'd even argue it should be a warning instead.
Added an overload for `WithAnalysisTech` that doesn't take a story goal. This way it's easier to write the same code for both SN and BZ.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request
resolves #402
fixes #466
KnownTechPatcherimplementation; special thanks to @vlyon for the suggestion in AnalysisTech & Unlocking #402AddRequirementForUnlockmethod that just adds blueprints to a requirement tech typeWithScannerEntryoverload for theScanningGadgetthat doesn't override a techtype's scanner entry that it has no business inScanningGadgetnow always adds analysis tech to the current tech type, when theWithAnalysisTechmethod is calledunlockallcommandAnalysisTech.Breaking changes
Deprecated methods
TODO:
KnownTechPatcher.RemovalTechsefficiently