Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the CloneTemplate #489

Merged

Conversation

MrPurple6411
Copy link
Member

@MrPurple6411 MrPurple6411 commented Oct 12, 2023

Changes made in this pull request

  • Add Overload to pass a AssetReferenceGameObject to clone by GUID or Asset Path.

Breaking changes

  • None

Copy link
Member

@Metious Metious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion. Other than that looks good to me.

Also this PR has no breaking changes as the changed stuff were all internal. Even if the SpawnType enum was public, adding a new one wouldn't break anything but custom enums for this type, which are unlikely.

Nautilus/Assets/PrefabTemplates/CloneTemplate.cs Outdated Show resolved Hide resolved
Co-authored-by: Metious <71298690+Metious@users.noreply.github.com>
@Metious Metious merged commit 86412ec into SubnauticaModding:master Oct 13, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
@MrPurple6411 MrPurple6411 deleted the CloneAssetReferenceGameObject branch October 24, 2023 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants