New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul ModPrefabRequest and PrefabHandler to fix multi request bug #508

Merged

MrPurple6411 merged 2 commits into master from ModPrefabRequestFix

Dec 17, 2023

Member

MrPurple6411 commented Dec 17, 2023

Changes made in this pull request

Debug Log when prefab is removed from cache
Reworked ModPrefabRequest to actually implement the Current, MoveNext, Reset and Release methods
Retargeted the ModPrefabRequest.TryGetPrefab to pull from the cache
Moved PrefabFactory call into the renamed InitPrefabAsync method.

MrPurple6411 added 2 commits

December 17, 2023 10:33


          Overhaul ModPrefabRequest and PrefabHandler to fix multi request bug

b185a3d


          Update PrefabHandler.cs

509a782

MrPurple6411 requested review from Metious and LeeTwentyThree

December 17, 2023 17:46

MrPurple6411 merged commit 62fc980 into master

3 checks passed

MrPurple6411 deleted the ModPrefabRequestFix branch

December 17, 2023 22:34

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.