Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefab requests array and lock cache dictionary #525

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Remove prefab requests array and lock cache dictionary #525

merged 6 commits into from
Jan 2, 2024

Conversation

LeeTwentyThree
Copy link
Member

@LeeTwentyThree LeeTwentyThree commented Jan 2, 2024 •
edited by Metious

Changes made in this pull request

  • Removed the dictionary of mod prefab requests. Now duplicate requests made around the same moment will wait for the first one to complete.
  • Prefab spawning (specifically coordinated spawns) should work as intended now.
  • Cache entries should never be duplicated.
  • Our previous approach made more sense, but wasn't thread safe. Coroutines are too fragile for that.

Breaking changes

  • Should be none

@LeeTwentyThree LeeTwentyThree merged commit 70c04ad into SubnauticaModding:master Jan 2, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Metious Metious Metious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeeTwentyThree @Metious