Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefab cache now resets #544

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Prefab cache now resets #544

merged 3 commits into from
Apr 25, 2024

Conversation

Metious
Copy link
Member

@Metious Metious commented Apr 13, 2024

Changes made in this pull request

  • Prefab cache now resets on world quit
  • Fixed ModPrefabCache.RemovePrefabFromCache() NRE
  • Fixed GameObjectExtensions.IsPrefab sometimes failing
  • Added more docs.

Breaking changes

  • Custom prefabs that have user-defined improperly-written first time caches (static fields) may start failing from this change.

Thorough testing is required

LeeTwentyThree
LeeTwentyThree approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for SN!
Also works for BZ!

@LeeTwentyThree LeeTwentyThree merged commit 9464432 into SubnauticaModding:master Apr 25, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeeTwentyThree LeeTwentyThree LeeTwentyThree approved these changes

@MrPurple6411 MrPurple6411 Awaiting requested review from MrPurple6411

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Metious @LeeTwentyThree