Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version strings now all implicity treated as having 4 groups with trailing zeros #164

Merged
merged 8 commits into from Aug 4, 2020
Merged

Version strings now all implicity treated as having 4 groups with trailing zeros #164

merged 8 commits into from Aug 4, 2020

Conversation

PrimeSonic
Copy link
Member

  • Fixed a bug where version 2.8 would not equal 2.8.0
  • added and updated unit tests

Closes #160

@PrimeSonic PrimeSonic self-assigned this Aug 4, 2020
@PrimeSonic PrimeSonic linked an issue Aug 4, 2020 that may be closed by this pull request
Version dependencies: 2.8 != 2.8.0 #160
Closed
toebeann
toebeann requested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@toebeann toebeann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting further fixes as this currently breaks comparisons as the left-hand side is being trimmed for the comparison but the right-hand side is instead being padded.

@PrimeSonic
- Refactored version string parsing into RequiredQMod
bac2034 
- Ensured that all version strings pass through the same code
@toebeann toebeann merged commit 7ef0a21 into devQ3 Aug 4, 2020
@toebeann toebeann deleted the FixVersionTrimming branch August 4, 2020 23:03
@toebeann toebeann mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toebeann toebeann toebeann approved these changes

@MrPurple6411 MrPurple6411 Awaiting requested review from MrPurple6411

Assignees

@PrimeSonic PrimeSonic

Labels
Priority: High Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version dependencies: 2.8 != 2.8.0
2 participants
@PrimeSonic @toebeann