-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a tester test tests/shop_owner_pause_resume_and_cancel_subscription is failing #826
Labels
released
This issue/pull request has been released.
Comments
chrisjsimpson
added a commit
that referenced
this issue
Mar 12, 2022
chrisjsimpson
added a commit
that referenced
this issue
Mar 12, 2022
🚀 Issue was released in |
🚀 Issue was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
As a tester test shop_owner_pause_resume_and_cancel_subscription is failing
With the error:
Error cancelling subscription. Request req_<id>: No such subscription: ''
https://github.com/Subscribie/subscribie/blob/master/tests/browser-automated-tests-playwright/tests/shop_owner_pause_resume_and_cancel_subscriptions.js
Describe the solution you'd like
Why failing? Because by
update_stripe_subscription_statuses
does not include canceld subscriptions, so the status is never updated.subscribie/subscribie/blueprints/admin/subscription.py
Line 27 in 13c6d4d
by default is not including canceled subscriptions, and therefore the subscription status change is not being captured. (Is this a change to the stripe api? Our tests used to pass for this) Not accoding to the docs: https://stripe.com/docs/upgrades#api-changelog but maybe here https://github.com/stripe/openapi/releases?page=1
Describe alternatives you've considered
For this process, list all subscriptions from the stripe api using
status=all
which will return allsubscriptions, including cancelled ones.https://stripe.com/docs/api/subscriptions/list#list_subscriptions-status
Additional context
steps to reproduce:
Add any other context or screenshots about the feature request here.
https://stripe.com/docs/api/subscriptions/list#list_subscriptions-status
The text was updated successfully, but these errors were encountered: