Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse country code from geo header #887

Merged
merged 16 commits into from
May 14, 2022
Merged

parse country code from geo header #887

merged 16 commits into from
May 14, 2022

Conversation

chrisjsimpson
Copy link
Contributor

@chrisjsimpson chrisjsimpson commented May 8, 2022 •
edited
Loading

Note: Requires changes to upstream proxy to detect country and inject as header, see https://github.com/KarmaComputing/geo-location-ip-country-serverside for example

@chrisjsimpson
wip Fix #886 parse country code from geo header
7cc64e7 
Display country of requesting visitor in footer
@chrisjsimpson
Fix #888 upgrade to python 3.10
e014292
@chrisjsimpson
wip Fix #886 parse country code from geo header
8f4423b 
Display country of requesting visitor in footer
@chrisjsimpson
#886 typo country.alpha_2 -> countryObj.alpha_2
b1b8814
@chrisjsimpson
Merge branch '886-store-client-request-country-in-request-header' of …
32a6044 
…github.com:Subscribie/subscribie into 886-store-client-request-country-in-request-header
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@chrisjsimpson
#886 remove globalTeardown/PLAYWRIGHT_GLOBALTEARDOWN
4c8f6ec 
todo: Remove test shops later than right after action finished, to help debugging
@chrisjsimpson chrisjsimpson temporarily deployed to testing May 13, 2022 23:27 Inactive
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@chrisjsimpson chrisjsimpson added the enhancement New feature or request label May 14, 2022
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@joeltejeda joeltejeda temporarily deployed to testing May 14, 2022 00:48 Inactive
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@chrisjsimpson chrisjsimpson temporarily deployed to testing May 14, 2022 20:25 Inactive
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@chrisjsimpson chrisjsimpson temporarily deployed to testing May 14, 2022 20:45 Inactive
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@chrisjsimpson chrisjsimpson temporarily deployed to testing May 14, 2022 20:57 Inactive
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@chrisjsimpson chrisjsimpson temporarily deployed to testing May 14, 2022 21:55 Inactive
@github-actions
Copy link

🙌 Live preview is here: http://886-store-client-request-country-in-request-header.pcpink.co.uk

@chrisjsimpson chrisjsimpson merged commit 52d6c4b into master May 14, 2022
@chrisjsimpson chrisjsimpson temporarily deployed to testing May 14, 2022 22:22 Inactive
@chrisjsimpson chrisjsimpson temporarily deployed to production May 14, 2022 22:22 Inactive
@github-actions
Copy link

🚀 PR was released in v0.1.85 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 14, 2022
@chrisjsimpson chrisjsimpson mentioned this pull request May 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As an app, Subscribie is aware from which country the visitor is coming from
2 participants
@chrisjsimpson @joeltejeda