feat!: multiple performance per task #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2023
ThibaultFy
force-pushed
the
feat/several-perf-output
branch
6 times, most recently
from
9adf1c4
to
3fdda70
Compare
ThibaultFy
force-pushed
the
feat/several-perf-output
branch
10 times, most recently
from
45a74de
to
38f93b2
Compare
SdgJlbl
reviewed
May 3, 2023
| MetricKey: "metricKey", | ||
| ComputeTaskKey: "taskKey", | ||
| MetricKey: "metricKey", | ||
| ComputeTaskOutputIdentifier: "performance", |
There was a problem hiding this comment.
why is a ComputeTaskOutputIdentifier named performance?
There was a problem hiding this comment.
It is just for the test. Before this PR, the identifier of a test task was always "performance" even if its a variable. But we could change the name if we want
There was a problem hiding this comment.
I feel like it would be more clear if something different was used, to show that we don't have to use the reserved keyword "performance". But that's a subjective opinion.
SdgJlbl
reviewed
May 3, 2023
| PerformanceValue: 3.14, | ||
| ComputeTaskKey: "taskUuid", | ||
| MetricKey: "metricUuid", | ||
| ComputeTaskOutputIdentifier: "performance", |
There was a problem hiding this comment.
same as above, wouldn't something like outputIdentifier be more clear?
There was a problem hiding this comment.
It's just an example of identifier
SdgJlbl
approved these changes
May 3, 2023
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
ThibaultFy
force-pushed
the
feat/several-perf-output
branch
from
c1017a0
to
e2ab397
Compare
ThibaultFy
commented
May 4, 2023
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Signed-off-by: ThibaultFy <50656860+ThibaultFy@users.noreply.github.com>
Merged
Milouu
added a commit
that referenced
this pull request
May 15, 2023
## [0.34.0](https://github.com/Substra/orchestrator/releases/tag/0.34.0) - 2023-05-11 ### Changed - A Performance in now unique regarding a compute task key, a metric key and a compute task output identifier ([#197](#197)) ### Removed - Metric from Performance ([#213](#213)) Signed-off-by: Milouu <milan.roustan@owkin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Performance asset were unique regarding their compute task key, and the function key they were computed from. Or, we want to have the possibility to have a function that outputs several performance and store them in the same task.
This implies two main things:
The PR batch modify both the orchestrator and backend db in order to include the identifier as an additional unique condition.
In the backend, we use the ComputeTaskOutput as primary key directly.
Companion PR
E2E tests
https://github.com/owkin/substra-ci/actions/runs/4872054802