feat!: add new compute tasks status linked to function status #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
2 tasks
7 tasks
guilhem-barthes
force-pushed
the
feat/add-new-compute-tasks-status-linked-to-function-status
branch
2 times, most recently
from
f733a8b
to
ea7d701
Compare
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
feat/add-new-compute-tasks-status-linked-to-function-status
branch
2 times, most recently
from
3985463
to
28992d7
Compare
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
feat/add-new-compute-tasks-status-linked-to-function-status
branch
from
28992d7
to
2793f02
Compare
…D_FINISHED` Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
ThibaultFy
reviewed
Feb 15, 2024
Comment on lines
+12
to
+17
| [*] --> waitingBuilding | ||
| [*] --> building | ||
| [*] --> waitingParent | ||
| [*] --> waitingExecutor | ||
| [*] --> failed | ||
| [*] --> canceled |
There was a problem hiding this comment.
A task can be registered directly as canceled or failed ?
There was a problem hiding this comment.
Yes, if the associated function is failed or canceled when the task is registered (as we can add tasks linked to a function at any time, the task could be added after we finish dealing with the function)
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
This was referenced Feb 15, 2024
guilhem-barthes
changed the title
guilhem-barthes
deleted the
feat/add-new-compute-tasks-status-linked-to-function-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR
Description
Fixes of FL-1397
How has this been tested?
Checklist