chore!: rename the "message" field in API responses to "detail" #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
/e2e |
|
End to end tests: ✔️ SUCCESS That was easy. |
7 tasks
oleobal
force-pushed
the
chore/message-to-detail
branch
from
7e2dd5f
to
f6dfe7b
Compare
Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
oleobal
force-pushed
the
chore/message-to-detail
branch
from
f6dfe7b
to
8d2bc30
Compare
Merged
Milouu
added a commit
that referenced
this pull request
Sep 7, 2023
### Added - New `SECRET_KEY` optional environment variable ([#671](#671)) - `/api-token-auth/` and the associated tokens can now be disabled through the `EXPIRY_TOKEN_ENABLED` environment variable and `server.allowImplicitLogin` chart value ([#698](#698)) - Tokens issued by `/api-token-auth/` can now be deleted like other API tokens, through a `DELETE` request on the `/active-api-tokens` endpoint ([#698](#698)) ### Changed - Increase the number of tasks displayable in frontend workflow [#697](#697) - BREAKING: Change the format of many API responses from `{"message":...}` to `{"detail":...}` ([#705](#705)) ### Removed - BREAKING: `SECRET_KEY_PATH` and `SECRET_KEY_LOAD_AND_STORE` environment variables ([#671](#671)) - Removed logic for storing `SECRET_KEY` at startup, in order to increase stability; it should be done at a higher level, i.e. the chart ([#671](#671)) ## Fixed - `/api-token-auth/` sometimes handing out tokens that are about to expire ([#698](#698)) Signed-off-by: Milouu <milan.roustan@owkin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On error (HTTP 4XX or 5XX), our API's JSON reponses are inconsistent. This is in large part because our own code returns
{"message": ...}but DRF returns{"detail": ...}.This changes all instances were we use
messagetodetailinstead (including in non-error responses).Companion PR: Substra/substra#379
This PR replaces #699, a previous attempt at this
How has this been tested?
I'm not sure how to test this works correctly :)
Checklist