Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user creation/edition validation #133

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: user creation/edition validation #133

merged 2 commits into from
Dec 19, 2022

Conversation

jmorel
Copy link
Contributor

@jmorel jmorel commented Oct 7, 2022

Signed-off-by: Jérémy Morel jeremy.morel@owkin.com

Linked to this ASANA TASK

Description

Companion PR: Substra/substra-backend#524

  • fixes a typo (hasCorrectLenght )
  • renames unclear method checkPasswordErrors into isPasswordValid
  • fixes the valid status of the PasswordInput component
  • displays toast and closes drawer only once the create/update call has returned. This also allows the list to be refreshed only once the creation/update has finished, which makes sure it contains the most up-to-date data
  • handles creation failure (error toast + do not close drawer)
  • disables create button if form is not valid
  • adds a loading status on the create button when the call is ongoing
  • disable inputs during update/creation

@jmorel jmorel force-pushed the fix/user_management branch 3 times, most recently from 6897a54 to 705adf3 Compare October 7, 2022 12:57
Signed-off-by: Jérémy Morel <jeremy.morel@owkin.com>
Signed-off-by: Milouu <milan.roustan@owkin.com>
@Milouu Milouu merged commit d2c40c5 into main Dec 19, 2022
@Milouu Milouu deleted the fix/user_management branch December 19, 2022 11:03
@Milouu Milouu mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants