Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Improve Find / Replace for Translation Modes #2839

Closed
LeonCheung opened this issue Mar 18, 2018 · 6 comments
Closed

[Suggestion] Improve Find / Replace for Translation Modes #2839

LeonCheung opened this issue Mar 18, 2018 · 6 comments

Comments

@LeonCheung
Copy link
Contributor

LeonCheung commented Mar 18, 2018

My proposal is: when in Translation mode, a new option could be seen in both Ctrl F and Ctrl H dialog window to allow ppl to choose the target column(s) they want to affect, to be exact, "current", "original" or both.

Currently, the problem is that such operations will take effect on both texts, with "Allow edit of original mode" enabled. However, sometimes we really want to edit texts for both subs, sometimes we just don't want to touch one of them, take Find / Replace for example. I think it would be so inefficient to temporally disable it for times. FYI. Thx.

@OmrSi
Copy link
Member

OmrSi commented Mar 25, 2018

Yeah, Also when you Unbreak the current, it Unbreaks the original. :\

@LeonCheung
Copy link
Contributor Author

LeonCheung commented Mar 28, 2018

@OmrSi Totally true, I was just about to update here and saw you did it already. :)

In that case, my suggestion would be leaving a toggle somewhere in the worknig area to enable/ disable editing original sub, instead of having to find it in General Setting, which is really handy when working in translation mode. Though I bet Nikolaj made it on purpose since some buttons like "Unbreak" disapear if you allow editing original sub.

@LeonCheung
Copy link
Contributor Author

A humble proto:
t

@OmrSi
Copy link
Member

OmrSi commented Mar 28, 2018

but we should still be able to copy thing from it when it is not allowed. :)

@LeonCheung
Copy link
Contributor Author

Alternative idea:
888

(The option can only be seen in Translation mode)

@OmrSi
Copy link
Member

OmrSi commented Jul 13, 2018

#2604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants