Better SplitLongLinesInSubtitle #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandrofly
commented
Feb 15, 2019
| spacing2++; | ||
| } | ||
|
|
||
| double duration = p.Duration.TotalMilliseconds / 2.0; |
There was a problem hiding this comment.
I think this is really wrong, we can't assume both line with have same amount of characters... this problem is handle in this PR.
Correct one should be:
d1 = (td / at) * (l1 - nl)
- d1: duration for paragraph one
- td: total duration
- at: all text
- l1: length of firstline
- nl: Environment.NewLine.Length
Cleaner and easy to read/understand
ivandrofly
commented
Feb 15, 2019
| { | ||
| return false; | ||
| } | ||
| string textNoTags = HtmlUtil.RemoveHtmlTags(text); |
There was a problem hiding this comment.
Handles if text ends with any of the supported html tags
|
It would be really nice if you could add some unit tests :) |
Done ✅ |
niksedk
reviewed
Feb 16, 2019
niksedk
reviewed
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.