Serilog003 gives false positive on my custom abstraction

[tiesmaster]

Hi, awesome analyzer, btw. I really like it. Though, I'm getting a false postive on the following line:

                int id = 1;
                _log.Error("The id is {Id}", id);

Where _log is an instance of our own abstraction ILogger (it might not be too valuable, but that's a different discussion), which looks like this:

    public interface ILogger
    {
        [MessageTemplateFormatMethod("messageTemplate")]
        void Debug(string messageTemplate);
        [MessageTemplateFormatMethod("messageTemplate")]
        void Debug(string messageTemplate, params object[] values);
        [MessageTemplateFormatMethod("messageTemplate")]
        void Error(string messageTemplate, params object[] values);
        [MessageTemplateFormatMethod("messageTemplate")]
        void Error(Exception exception, string messageTemplate, params object[] values);
        [MessageTemplateFormatMethod("messageTemplate")]
        void Information(string messageTemplate);
        [MessageTemplateFormatMethod("messageTemplate")]
        void Information(string messageTemplate, params object[] values);
        [MessageTemplateFormatMethod("messageTemplate")]
        void Warning(string messageTemplate, params object[] propertyValues);
        [MessageTemplateFormatMethod("messageTemplate")]
        void Warning(string messageTemplate);
    }

And with that, it will give me:

1>C:\src\duprix\DuPrix.Services\CompetitorPricing\RecommendationService.cs(124,39,124,43): error Serilog003: Error while binding properties: There is no argument that corresponds to the named property 'Id'

If I have time, I'll see if I can reproduce this in a unit test, and sent you a PR, if you're accepting.

[Suchiman]

My guess would be that its related to the way how i determine parameters:
https://github.com/Suchiman/SerilogAnalyzer/blob/master/SerilogAnalyzer/SerilogAnalyzer/DiagnosticAnalyzer.cs#L153
That makes me wonder right now if the code even works with params object[] (it checks Name.StartsWith("propertyValue") since in the generic overloads, they're numbered T1 propertyValue1, T2 propertyValue2)

[tiesmaster]

Indeed, looks that way. If I have time this easter weekend, I'll take a stab at it. You're accepting PRs, right?

[Suchiman]

Of course 👍 much appreciated

[tiesmaster]

@Suchiman A coworker of mine ran into this issue again the other day, so it would be nice if this fix would be released. Are you planning a release by any chance?

[Suchiman]

Sorry, i've been slacking lately.
I will do a point release this evening to get the fix out.

[Suchiman]

@tiesmaster I've just pushed https://github.com/Suchiman/SerilogAnalyzer/releases/tag/0.9.1 to nuget and visual studio gallery

[tiesmaster]

Awesome! I'll update my repos straight away tomorrow. Thanks man!