Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource library #547

Merged
merged 10 commits into from
May 30, 2024
Merged

Conversation

dhruv8433
Copy link
Contributor

@dhruv8433 dhruv8433 commented May 29, 2024

@Suchitra-Sahoo

please check this and merge it

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]

Feat: Add Detailed page for resource library #501

Description

[Please include a brief description of the changes or features added]

  • i updated our index page and only show there 3 resourece cards
  • added one button under that see more
  • when useer click on that we redirect them to /resource-library page

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

home page /index

image

when user click on see more button we redirect them to /resource-library

route /resourse-library

image

in responsive

image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

@Suchitra-Sahoo
Copy link
Owner

Hey kindly attach a video to demonstrate your changes. Also have you checked whether all components are clearly visible and aligned for small devices also?

@Suchitra-Sahoo
Copy link
Owner

Recently some changes in navbar have been merged so pull all of them from origin

@dhruv8433
Copy link
Contributor Author

@Suchitra-Sahoo

now you can merge it

@Suchitra-Sahoo
Copy link
Owner

Before merging I want you to attach a video too so that in case there is some changes i can tell you rather than merging and reverting back again.

@dhruv8433
Copy link
Contributor Author

@Suchitra-Sahoo

here is video of that

AgriLearnNetwork.Mozilla.Firefox.2024-05-30.08-26-29.mp4

@Suchitra-Sahoo
Copy link
Owner

Instead of keeping just 3 videos on main page seperately create page for resource library. And the shape of the card should be even from all sides. If you go and check the websit link you will find when we hover on the card then youtube video slides up so that the user can also see the video within the card as well as on youtube. So keep that same. And pull all changes too.

@Suchitra-Sahoo
Copy link
Owner

Also improve the background.

@dhruv8433
Copy link
Contributor Author

ok i will do that

@dhruv8433
Copy link
Contributor Author

@Suchitra-Sahoo

check this out
home page now look like

image

when user click on navigation link resource library they will redirected to /resource-library
and when we hover on the card then youtube video slides up so that the user can also see the video within the card as well as on youtube.

as you said,

image

@Suchitra-Sahoo
Copy link
Owner

I think you have done some changes in contact us like "submit query" and dropdown in mobile no so remove them.

@dhruv8433
Copy link
Contributor Author

No, i don't even touch contact us code

my index.html's contact us is same as upstream main's contact us

@dhruv8433
Copy link
Contributor Author

@Suchitra-Sahoo

kindlty please check this and response

@Suchitra-Sahoo Suchitra-Sahoo merged commit b648516 into Suchitra-Sahoo:main May 30, 2024
1 check passed
@Suchitra-Sahoo
Copy link
Owner

@dhruv8433 I had to revert back your PR as the resource library page is not linking properly.Kindly check on it.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants