Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign "view options" menu into a dialog #240

Open
ericwa opened this issue Feb 5, 2017 · 1 comment
Open

Redesign "view options" menu into a dialog #240

ericwa opened this issue Feb 5, 2017 · 1 comment

Comments

@ericwa
Copy link
Contributor

ericwa commented Feb 5, 2017

The "view options" menu could make better use of the available space by changing from a menu into a special-purpose dialog.

Some ideas:

  • Change night mode checkbox to a horizontal list of color swatches:
    • black on white
    • white on black
    • brown on sepia
    • etc. (user defined tint presets?)
  • "Force portrait / force landscape / use device default" could be made a single button that cycles through those 3 options.
  • we may want to hide some of the labels for buttons and use icons only, so multiple icons can be stacked horizontally (needs to be done carefully.)
  • Could use two tabs like Play Books, since we have a lot of settings in DV.

For reference here are some screenshots of current DV, Kindle, and Play Books:

screenshot_2017-02-05-14-06-49-841_org sufficientlysecure viewer

Kindle:
screenshot_2017-02-05-13-34-34-793_com amazon kindle

Play books:
screenshot_2017-02-05-13-31-07-126_com google android apps books

screenshot_2017-02-05-13-31-13-678_com google android apps books

@Daedalon
Copy link

Daedalon commented Feb 13, 2017

Generally speaking, I like the menu as it is, or at least haven't considered it negatively before seeing this thread. I've only ever felt the temptation to try only a fraction of the options available though.

If we want to clean up, the simplest step would be if we can remove some options completely from here. Do all of these serve a purpose? At least I've never used Full screen from here, because tapping anywhere in the book switches between full screen. Show Title is another one I haven't used either (it also happens to be inconsistent in the capitalization viz the other menu items). Also, what about Set as thumbnail? Didn't even notice that option before, and don't immediately have an idea what would I want to use it for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants