Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #42

Closed
ghost opened this issue Sep 10, 2015 · 3 comments
Closed

Dark theme #42

ghost opened this issue Sep 10, 2015 · 3 comments
Labels

Comments

@ghost
Copy link

@ghost ghost commented Sep 10, 2015

Actually the dark Holo versions looked more materialish then the full-white one. Could you add a setting for toggling the themes? Maybe a colored actionbar would be okay, too, but I'd rather prefer dark themes :/

@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Mar 14, 2016

I started work on this at https://github.com/krt16s/offline-calendar/commit/81e8a9d26dac24d66003a40872846380fd9e53ab. Since I am not an experienced Android developer (wouldn't even call me a developer at all -- I read through documentation and StackOverflow...), I could really use some review and guidance:

Basically it works, I don't know if it's properly done. E.g. I really don't know if there is a way to apply a theme in a single location -- currently I do it for all three activities. I am missing the actionbar in preferences as well...

@dschuermann

This comment has been minimized.

Copy link
Member

@dschuermann dschuermann commented Mar 18, 2016

Hey @krt16s
The code looks okay :)
Can you make a pull request? That makes it easier to discuss changes.

@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Mar 18, 2016

Ref: #54

@dschuermann dschuermann closed this May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.