Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: add a scrubber to the audio playback button; don't display any audio controls until the new one is rendered #57

Open
nonprofittechy opened this issue Mar 18, 2021 · 1 comment
Labels
CSS upstream/core Track issues that would be fixed upstream before we're ready to create an upstream issue
Milestone

Comments

@nonprofittechy
Copy link
Member

See #29 for longer discussion.

I think we have just two fixes left to make:

  1. Add a scrubber/way to reposition the audio playback. We discussed having this be something that only shows when the screen is being read aloud. It would display/collapse like an accordion.
  2. Right now the old audio UI shows for a few seconds before the new one is rendered. It would be nice to have the old audio control start out hidden.
@nonprofittechy nonprofittechy added this to the Future milestone Mar 18, 2021
@BryceStevenWilley
Copy link
Contributor

2 is a bit difficult, we're already hiding the old UI as soon as we can, right after a daPageLoad. We'd have to change DA core to have the audio controls start out as hidden. for it to be completely hidden the whole time and not pop up.

@nonprofittechy nonprofittechy added the upstream/core Track issues that would be fixed upstream before we're ready to create an upstream issue label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS upstream/core Track issues that would be fixed upstream before we're ready to create an upstream issue
Projects
None yet
Development

No branches or pull requests

2 participants