remove icon from intro screen that was never displayed #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryceStevenWilley
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
LGTM; the only other place I see it is in https://github.com/A2JatAKCourts/docassemble-AKA2JBranding/blob/7a7b31484d5d5a4c3247f0cae00da096f976c058/docassemble/AKA2JBranding/data/questions/custom_organization.yml#L50, tagging @CaroRob just so she knows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #736
Looks like this was meant to be a decoration for the main intro page. I found the icon w/ the attribution, but it's now behind a paywall so we can't easily just add it back in anyway.
It's not a bad idea to have some visual here, but given #461 and the fact that this decoration appears to have never been visible, going to just remove it for now as the safest choice.
We can decide to add more graphics later, probably shouldn't do it in the default theme without notice though.