Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Commit

Permalink
Don't raise if save fails
Browse files Browse the repository at this point in the history
  • Loading branch information
Tuuleh committed Jul 8, 2016
1 parent 20a9660 commit 23d4804
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion app/controllers/api/members_controller.rb
Expand Up @@ -3,7 +3,7 @@ class Api::MembersController < ApplicationController
def create
member = Member.find_or_initialize_by(email: member_params[:email])
member.assign_attributes(member_params)
if member.save!
if member.save
member.send_to_ak
render json: { member: member }
else
Expand Down
14 changes: 7 additions & 7 deletions spec/requests/api/members_spec.rb
Expand Up @@ -6,14 +6,15 @@ def json
JSON.parse(response.body)
end

let(:params) {{ email: "newbie@test.org", country: "NZ", postal: "1A943", name: "Anahera Parata" }}

subject do
post api_members_path, email: "newbie@test.org", country: "NZ", postal: "1A943", name: "Anahera Parata"
post api_members_path, params
end

describe 'POST api/members' do

let!(:existing_member) { create :member, email: "oldie@test.org", name: "Oldie Goldie", country: "SWE", postal: 12880 }
let(:new_member) { create :member, email: "newbie@test.org", country: "NZ", postal: "1A943", name: "Anahera Parata" }

it "creates a new member" do
expect{subject}.to change {Member.count}.by(1)
Expand All @@ -32,16 +33,15 @@ def json
end

it "posts a message on the AK worker queue to create a new user in AK" do
allow(Member).to receive(:find_or_initialize_by).and_return(new_member)
allow(ChampaignQueue).to receive (:push)
subject
expect(ChampaignQueue).to have_received(:push).with(
type: 'subscribe_member',
params: {
email: new_member.email,
name: new_member.name,
country: new_member.country,
postal: new_member.postal
email: params[:email],
name: params[:name],
country: params[:country],
postal: params[:postal]
}
)
end
Expand Down

0 comments on commit 23d4804

Please sign in to comment.