Merge pull request #1437 from SumOfUs/fix.protect_member

https://app.asana.com/0/1119304937718815/1119306613181944
SumOfUs · Jul 22, 2019 · 9508e35 · 9508e35
2 parents e277a5e + db8dfbf
commit 9508e35
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -17,13 +17,13 @@ Style/FrozenStringLiteralComment:
 Layout/IndentationConsistency:
   EnforcedStyle: normal
 
-Layout/IndentArray:
+Layout/IndentFirstArrayElement:
   EnforcedStyle: consistent
 
-Layout/IndentHash:
+Layout/IndentFirstHashElement:
   EnforcedStyle: consistent
 
-Layout/FirstParameterIndentation:
+Layout/IndentFirstArgument:
   EnforcedStyle: consistent
 
 Layout/MultilineMethodCallIndentation:

diff --git a/app/controllers/email_confirmation_controller.rb b/app/controllers/email_confirmation_controller.rb
@@ -2,7 +2,7 @@
 
 class EmailConfirmationController < ApplicationController
   before_action :find_member
-  before_action :find_payment_methods
+  before_action :set_payment_methods
 
   def verify
     begin
@@ -21,10 +21,11 @@ def verify
   def find_member
     raise ActiveRecord::RecordNotFound if params[:email].blank?
 
-    @member = Member.find_by_email!(params[:email])
+    Member.find_by_email!(params[:email])
+    @member = nil
   end
 
-  def find_payment_methods
-    @payment_methods = payment_methods
+  def set_payment_methods
+    @payment_methods = []
   end
 end