rubocop

app/models/payment/braintree/transaction.rb

@@ -35,8 +35,8 @@ def publish_subscription_charge
     ChampaignQueue.push({
       type: 'subscription-payment',
       params: {
-        recurring_id: self.subscription.try(:action).form_data['subscription_id'],
-        success: self.status == 'success' ? 1 : 0
+        recurring_id: subscription.try(:action).form_data['subscription_id'],
+        success: status == 'success' ? 1 : 0
       }
     }, { delay: 120 })
   end

spec/models/payment/braintree/transaction_spec.rb

@@ -98,20 +98,19 @@
   end
 
   describe 'publish subscription payment' do
-    let(:action) { create(:action, form_data: {'subscription_id' => 'subscription_id'}) }
+    let(:action) { create(:action, form_data: { 'subscription_id' => 'subscription_id' }) }
     let(:subscription) { create(:payment_braintree_subscription, subscription_id: 'subscription_id', action: action) }
     let(:transaction) { create(:payment_braintree_transaction, subscription: subscription, status: 'success') }
     it 'pushes a subscription payment event with a status to the queue' do
       expected_payload = {
-                            type: 'subscription-payment',
-                            params: {
-                              recurring_id: 'subscription_id',
-                              success: 1
-                            }
-                          }
+        type: 'subscription-payment',
+        params: {
+          recurring_id: 'subscription_id',
+          success: 1
+        }
+      }
       expect(ChampaignQueue).to receive(:push).with(expected_payload, delay: 120)
       transaction.publish_subscription_charge
     end
-
   end
 end

spec/requests/api/braintree/webhook_spec.rb

@@ -98,7 +98,8 @@
           expected_payload = {
             type: 'subscription-payment',
             params: {
-              recurring_id: /[a-z0-9]{6}/
+              recurring_id: /[a-z0-9]{6}/,
+              success: 1
             }
           }
 
@@ -148,7 +149,8 @@
           expected_payload = {
             type: 'subscription-payment',
             params: {
-              recurring_id: /[a-z0-9]{6}/
+              recurring_id: /[a-z0-9]{6}/,
+              success: 1
             }
           }