Rename 'share_count' to 'conversion_count' for whatsapp shares

SumOfUs · Jun 8, 2018 · aeafe1d · aeafe1d
1 parent 4f6565f
commit aeafe1d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/app/javascript/member-facing/track_shares.js b/app/javascript/member-facing/track_shares.js
@@ -1,5 +1,4 @@
 import $ from 'jquery';
-//TODO: Fix this import :) And rename / modify this file to hide the whatsapp button if the person is not on a mobile device
 import MobileCheck from './backbone/mobile_check';
 
 $(() => {

diff --git a/app/models/share/whatsapp.rb b/app/models/share/whatsapp.rb
@@ -12,6 +12,7 @@
 #  updated_at  :datetime         not null
 #  click_count :integer
 #  share_count :integer
+#  conversions :integer
 
 class Share::Whatsapp < ApplicationRecord
   include Share::Variant

diff --git a/db/migrate/20180507153911_create_share_whatsapps.rb b/db/migrate/20180507153911_create_share_whatsapps.rb
@@ -5,7 +5,7 @@ def change
       t.string :text
       t.integer :button_id
       t.integer :click_count
-      t.integer :share_count
+      t.integer :conversion_count
 
       t.timestamps null: false
     end

diff --git a/spec/factories/share_whatsapps.rb b/spec/factories/share_whatsapps.rb
@@ -10,13 +10,16 @@
 #  button_id   :integer
 #  created_at  :datetime         not null
 #  updated_at  :datetime         not null
-#
+#  click_count :integer
+#  conversion_count :integer
 
 FactoryGirl.define do
   factory :share_whatsapp, class: 'Share::Whatsapp' do
     id 1
     page nil
     text 'MyMessage {LINK}'
     button_id 1
+    click_count 1
+    conversion_count 1
   end
 end
diff --git a/spec/models/share/whatsapp_spec.rb b/spec/models/share/whatsapp_spec.rb
@@ -11,7 +11,7 @@
 #  created_at  :datetime         not null
 #  updated_at  :datetime         not null
 #  click_count :integer
-#  share_count :integer
+#  conversion_count :integer
 
 require 'rails_helper'