Return 'get_page' before action, and add spec

app/controllers/api/pages_controller.rb

@@ -1,8 +1,6 @@
-require 'rack'
-
 class Api::PagesController < ApplicationController
-
   before_action :set_language, only: [:show, :show_featured]
+  before_action :get_page, except: [:show, :show_featured]
 
   layout false
 
@@ -16,7 +14,6 @@ def update
   end
 
   def share_rows
-    get_page
     render json: (@page.shares.map do |s|
       {html: render_to_string(partial: "share/#{s.name}s/summary_row", locals: {share: s, page: @page})}
     end)
@@ -38,7 +35,6 @@ def show_featured
     else
       render json: pages_by_language.where(featured: true)
     end
-
   end
 
   private

spec/controllers/api/pages_controller_spec.rb

@@ -0,0 +1,31 @@
+require 'rails_helper'
+
+describe Api::PagesController do
+  let(:page) { instance_double('Page', id: 1, to_param: '1') }
+  let(:page_updater) { double(update: true, refresh?: true) }
+
+  before do
+    allow(Page).to receive(:find){ page }
+    allow(PageUpdater).to receive(:new) { page_updater }
+  end
+
+  describe 'PUT update' do
+    before do
+      put :update, id: 1
+    end
+
+    it 'finds page' do
+      expect(Page).to have_received(:find).with('1')
+    end
+
+    context 'PageUpdater' do
+      it 'is instantiated' do
+        expect(PageUpdater).to have_received(:new).with(page, "http://test.host/pages/1")
+      end
+
+      it 'calls update with params' do
+        expect(page_updater).to have_received(:update).with({})
+      end
+    end
+  end
+end

spec/requests/api/pages_spec.rb

@@ -63,7 +63,6 @@ def json
     end
 
     describe 'with languages that exist' do
-
       include_context "shared language pages" do
         [:de,:fr,:en,:es].each do |language_code|
           it "in #{language_code}, it gets pages only in that language" do
@@ -73,7 +72,6 @@ def json
           end
         end
       end
-
     end
   end
 
@@ -91,7 +89,6 @@ def json
     end
 
     context 'with languages' do
-
       describe 'with language that does not exist' do
         it 'returns json with error' do
           get api_pages_featured_path, {language: 'klingon'}
@@ -110,8 +107,6 @@ def json
           end
         end
       end
-
     end
-
   end
 end