Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Commit

Permalink
Flow fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
vincemtnz committed Apr 26, 2019
1 parent 04a6441 commit d4238b9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
13 changes: 7 additions & 6 deletions app/javascript/modules/EmailParliament/EmailComposer.js
Expand Up @@ -30,7 +30,9 @@ export default (props: Props) => {
const [submitting, setSubmitting] = useState(false);
const [errors, setErrors] = useState(subject);

if (!props.target) return null;
const target = props.target;

if (!target) return null;

const onSubmit = async e => {
e.preventDefault();
Expand All @@ -40,14 +42,13 @@ export default (props: Props) => {
const result = await sendEmail({
pageId: window.champaign.page.id,
recipient: {
name: props.target.displayAs,
email: props.target.email,
name: target.displayAs,
email: target.email,
},
sender: { name, email },
subject,
body,
country: 'GB',
consented: true,
});
} catch (failure) {
console.log('there was an error');
Expand All @@ -62,7 +63,7 @@ export default (props: Props) => {
};

const templateVars = {
target: props.target,
target,
name,
email,
};
Expand All @@ -72,7 +73,7 @@ export default (props: Props) => {
<form onSubmit={onSubmit}>
<h3 className="EmailComposer-title">{props.title}</h3>
<FormGroup>
<Representative target={props.target} />
<Representative target={target} />
</FormGroup>
<FormGroup>
<SweetInput
Expand Down
7 changes: 3 additions & 4 deletions app/javascript/modules/EmailParliament/api.js
Expand Up @@ -19,6 +19,7 @@ export const search = async (postcode: ?string) => {
};

type SendEmailParams = {
pageId: string,
recipient: {
name: string,
email: string,
Expand All @@ -33,8 +34,7 @@ type SendEmailParams = {
};

type SendEmailPayload = {
page_id: string,
target: {
recipient: {
name: string,
email: string,
},
Expand All @@ -46,7 +46,7 @@ type SendEmailPayload = {
country: string,
},
tracking_params: { [key: string]: string },
consented: boolean,
consented?: boolean,
};

export const sendEmail = async (params: SendEmailParams) => {
Expand All @@ -58,7 +58,6 @@ export const sendEmail = async (params: SendEmailParams) => {
country: params.country,
from_name: params.sender.name,
from_email: params.sender.email,
consented: params.consented,
},
tracking_params: pick(
window.champaign.personalization.urlParams,
Expand Down

0 comments on commit d4238b9

Please sign in to comment.