show share stats on analytics page

SumOfUs · Mar 30, 2016 · f4077a4 · f4077a4
1 parent afb2194
commit f4077a4
Show file tree

Hide file tree

Showing 7 changed files with 57 additions and 36 deletions.
diff --git a/app/views/pages/_share_analytics_header.slim b/app/views/pages/_share_analytics_header.slim
@@ -0,0 +1,18 @@
+th
+th = "Content"
+th
+  = t('share.analytics.shares')
+  = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.shares'), space_left: true }
+th
+  = t('share.analytics.successful_shares')
+  = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.successful_shares'), space_left: true }
+th
+  = t('share.analytics.conversion_rate')
+  = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.conversion_rate'), space_left: true }
+th
+  = t('share.analytics.weight')
+  = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.traffic_allocation'), space_left: true }
+th
+  = t('share.analytics.winner')
+  = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.winner'), space_left: true }
+th
diff --git a/app/views/pages/_shares_editor.slim b/app/views/pages/_shares_editor.slim
@@ -5,24 +5,7 @@
 
   table.table.shares-editor__existing
     thead.shares-editor__stats-heading.hidden-closed
-      th
-      th = "Content"
-      th
-        = t('share.analytics.shares')
-        = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.shares'), space_left: true }
-      th
-        = t('share.analytics.successful_shares')
-        = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.successful_shares'), space_left: true }
-      th
-        = t('share.analytics.conversion_rate')
-        = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.conversion_rate'), space_left: true }
-      th
-        = t('share.analytics.weight')
-        = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.traffic_allocation'), space_left: true }
-      th
-        = t('share.analytics.winner')
-        = render partial: 'tooltip', locals: { tooltip_text: t('tooltips.shares.winner'), space_left: true }
-      th
+      = render 'share_analytics_header'
 
     tbody
       - @variations.each do |variation|

diff --git a/app/views/pages/analytics.slim b/app/views/pages/analytics.slim
@@ -30,7 +30,13 @@
           .analytics-chart.mini-new.mini
             svg.chart
 
+  table.table
+    thead.shares-editor__stats-heading
+      = render 'share_analytics_header'
 
+    tbody
+      - @page.shares.each do |variation|
+        = render variation, page: @page, only_stats: true
 
 javascript:
   $( function() {

diff --git a/app/views/share/_stats_row.slim b/app/views/share/_stats_row.slim
@@ -1,6 +1,7 @@
+- only_stats = false unless defined?(only_stats) && only_stats
 - analytics = ShareAnalytics.data(page, share_type, share )[0]
 
-tr.shares-editor__stats-row.hidden-closed
+tr.shares-editor__stats-row class="#{only_stats ? '' : 'hidden-closed'}"
   td
     - case share_type
     - when "twitter"
@@ -19,5 +20,6 @@ tr.shares-editor__stats-row.hidden-closed
   - else
     td colspan=5
       = t('share.analytics.no_data')
-  td.shares-editor__button-cell = render 'share/btn_edit_share'
-
+  td.shares-editor__button-cell
+    - unless only_stats
+      = render 'share/btn_edit_share'
diff --git a/app/views/share/emails/_email.html.slim b/app/views/share/emails/_email.html.slim
@@ -1,6 +1,10 @@
-= render 'share/emails/summary_row', share: email
-= render 'share/stats_row', share: email, share_type: 'email', page: page, preview: email.subject
+- only_stats = false unless defined?(only_stats) && only_stats
 
-tr.shares-editor__edit-row.hidden-closed
-  td colspan=8
-    = render 'share/form', page: page, share: email
+- unless only_stats
+  = render 'share/emails/summary_row', share: email
+= render 'share/stats_row', share: email, share_type: 'email', page: page, preview: email.subject, only_stats: only_stats
+
+- unless only_stats
+  tr.shares-editor__edit-row.hidden-closed
+    td colspan=8
+      = render 'share/form', page: page, share: email
diff --git a/app/views/share/facebooks/_facebook.html.slim b/app/views/share/facebooks/_facebook.html.slim
@@ -1,6 +1,10 @@
-= render 'share/facebooks/summary_row', share: facebook
-= render 'share/stats_row', share: facebook, share_type: 'facebook', page: page, preview: facebook.title
+- only_stats = false unless defined?(only_stats) && only_stats
 
-tr.shares-editor__edit-row.hidden-closed
-  td colspan=8
-    = render 'share/form', page: page, share: facebook
+- unless only_stats
+  = render 'share/facebooks/summary_row', share: facebook
+= render 'share/stats_row', share: facebook, share_type: 'facebook', page: page, preview: facebook.title, only_stats: only_stats
+
+- unless only_stats
+  tr.shares-editor__edit-row.hidden-closed
+    td colspan=8
+      = render 'share/form', page: page, share: facebook
diff --git a/app/views/share/twitters/_twitter.html.slim b/app/views/share/twitters/_twitter.html.slim
@@ -1,6 +1,10 @@
-= render 'share/twitters/summary_row', share: twitter
-= render 'share/stats_row', share: twitter, share_type: 'twitter', page: page, preview: twitter.description
+- only_stats = false unless defined?(only_stats) && only_stats
 
-tr.shares-editor__edit-row.hidden-closed
-  td colspan=8
-    = render 'share/form', page: page, share: twitter
+- unless only_stats
+  = render 'share/twitters/summary_row', share: twitter
+= render 'share/stats_row', share: twitter, share_type: 'twitter', page: page, preview: twitter.description, only_stats: only_stats
+
+- unless only_stats
+  tr.shares-editor__edit-row.hidden-closed
+    td colspan=8
+      = render 'share/form', page: page, share: twitter