This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
UTF-8 invalid charset #1054
Merged
UTF-8 invalid charset #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all ISO-8859 charsets are ASCII-8BIT compatible, they're a good fallback (compatible with Windows-1252). I've chosen ISO-8859-15 since it supports a range of latin chars: accents, tildes, etc.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt UTF-8 then fallback to ISO-8859-15. Since all ISO-8859 charsets are ASCII-8BIT compatible, they're a good fallback (compatible with Windows-1252). I've chosen ISO-8859-15 since it supports a range of latin chars: accents, tildes, etc.
How could we test this?