Fundraiser login & ActionForm bug fix #1096
Conversation
app/javascript/packs/fundraiser.js
Outdated
| @@ -88,3 +88,5 @@ window.mountFundraiser = function(root: string, data: MountFundraiserOptions) { | |||
| }); | |||
| } | |||
| }; | |||
|
|
|||
| window.storeDispatch = dispatch; | |||
There was a problem hiding this comment.
Had you intended on keeping this global?
There was a problem hiding this comment.
yeah, I need to expose the store to our petition backbone app. Is there any other way to do this?
There was a problem hiding this comment.
Left a comment on the other PR: the redux store is in window.champaign.store so you'll have access to store.dispatch(), store.getState(), store.subscribe(), etc.
There was a problem hiding this comment.
good idea, I'll change it
There was a problem hiding this comment.
Actually, the store was already in window.champaign.store. Changing the code to use that.
| prefill() { | ||
| const data = {}; | ||
| for (const field of this.props.fields) { | ||
| data[field.name] = | ||
| this.getPrefillValue(field.name) || field.default_value; | ||
| data[field.name] = this.props.formValues[field.name] |
There was a problem hiding this comment.
Did you mean this.props.formValues ? ... : ... here? It seems from the former getPrefillValue that the prop might be undefined / null.
There was a problem hiding this comment.
Actually, it's already there! I was confused. The ternary operator expands to multiple lines, check the following 2 lines.
There was a problem hiding this comment.
Yeah, but the first line tries to access a property (but the object could be undefined).
There was a problem hiding this comment.
Although I'm not sure if it's intended or just being overprotective? formValues is always an object in the reducer.
There was a problem hiding this comment.
Ideally the store should make sure that formValues is always an object, but right now it's not doing that. I'll add the check.
| @@ -159,15 +154,15 @@ export class MemberDetailsForm extends Component { | |||
| onSubmit={this.submit.bind(this)} | |||
| className="form--big action-form" | |||
| > | |||
| {this.props.fields.map((field, ii) => | |||
| {this.props.fields.map((field, ii) => ( | |||
There was a problem hiding this comment.
Seems like ii is unused here (although that was also there from the previous version, but worth cleaning up)
| @@ -130,12 +132,13 @@ export class FundraiserView extends Component { | |||
| } | |||
| fields={fields} | |||
| outstandingFields={outstandingFields} | |||
| prefillValues={formValues} | |||
| formValues={formValues} | |||
rodrei
force-pushed
the
fundraiser-login
branch
from
60d7855
to
8b4c2be
Compare
rodrei
force-pushed
the
fundraiser-login
branch
from
0ae042d
to
e46d9aa
Compare
Added
login_memberaction to fundraiser store. This allows the member information to be set after the component has been initialized.Modified
action_form.jsto publish the form data after being submitted.Fixed bug that caused
action_formto submit wrong values. The action form prefilling logic was broken, and was actually modifying the DOM in a wrong way (specifically checkboxes and radio buttons). The radio buttons, check boxes and textareas prefilling doesn't work (and wasn't working before either).