Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Email Tool: Added ability to add targets by entering the CSV in a text field #1130

Closed
wants to merge 2 commits into from

Conversation

rodrei
Copy link
Contributor

@rodrei rodrei commented Apr 9, 2018

screen shot 2018-04-09 at 2 15 01 pm

@rodrei rodrei changed the title Added the ability to add targets by entering the CSV in a text field Email Tool: Added ability to add targets by entering the CSV in a text field Apr 9, 2018
@osahyoun
Copy link
Member

Lovely stuff, @rodrei. This looks good to me.

@vincemtnz
Copy link
Contributor

vincemtnz commented Apr 10, 2018

I'm sort of worried that if a campaigner just wants to append to the list, they will have to paste the entire list of targets (which they might not have at hand), then add theirs at the bottom.

@rodrei
Copy link
Contributor Author

rodrei commented Apr 10, 2018

@eyko I agree that's an issue. We could fix this by prefilling the textarea with the CSV version of the targets list (I'll try to get that in before merging).
Ideally I'd have a nicer UI using a React component using rows of textfields (one per field), and having the ability to add new rows with a "+" button. I don't think it's a big lift but I tried to comply with the ticket without spending too much extra time trying to do a fancy UI.

@osahyoun
Copy link
Member

@rodrei was this ready to be merged?

@rodrei
Copy link
Contributor Author

rodrei commented Apr 23, 2018

This is already merged, closing.

@rodrei rodrei closed this Apr 23, 2018
@osahyoun osahyoun deleted the email-tool.targets-by-text branch May 2, 2018 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants