This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Fix EmailEditor subject field #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincemtnz
force-pushed
the
bugfix-fix-subject-email-editor
branch
from
d4d5c0b
to
ba14ad8
Compare
|
@eyko 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the recent changes to
shouldComponentUpdateto improve performance introduced this bug. We were only checking for changes in the Editor state, bug ignoring changes in the Subject, so the DOM element wasn't being updated with the text (it's a controlled element). This fixes it.This also adds a
MAX_SUBJECT_LENGTH, set to 64 characters.