This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Various bugfixes #1187
Merged
Various bugfixes #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincemtnz
commented
Jun 14, 2018
vincemtnz
commented
- Don't attempt to assign petitionForm to jXHR response if it's a string
- Paragraph spacing fixed
- i18n undefined may be fixed.
The _fundraiser_refactor.liquid partial has been deleted and its contents are now in _fundraiser.liquid. All templates that referenced 'Fundraiser Refactor' must be updated to include 'Fundraiser'.
Instead of doing this in ComponentWrapper, add it immediately in member_facing.js
vincemtnz
pushed a commit
that referenced
this pull request
Jun 18, 2018
* Don't run simple_format on emails body * Update email spec Since removing simple_format, the text is no longer wrapped in <p></p> * [hack] check to see if $ is being clobbered somewhere. (#1185) We're seeing a lot of errors telling us that `$` is not a function. We suspect that something's messing up with jQuery but we're not entirely sure. This is a small hack to hopefully re-assign jQuery to the `$` variable. 🤞 * Update pension emails spec * Various bugfixes (#1187) * import I18n from 'champaign-i18n' (alias to window.I18n in webpack) * Deprecate legacy backbone fundraiser code. The _fundraiser_refactor.liquid partial has been deleted and its contents are now in _fundraiser.liquid. All templates that referenced 'Fundraiser Refactor' must be updated to include 'Fundraiser'. * Add global locale data in member_facing.js Instead of doing this in ComponentWrapper, add it immediately in member_facing.js * Removed unused lines * Don't attempt to assign petitionForm to jXHR response if it's a string * Redo: "Release (#1188)" This reverts commit 40ba347. * Set user context in sentry
vincemtnz
pushed a commit
that referenced
this pull request
Jul 3, 2018
* Don't run simple_format on emails body * Update email spec Since removing simple_format, the text is no longer wrapped in <p></p> * [hack] check to see if $ is being clobbered somewhere. (#1185) We're seeing a lot of errors telling us that `$` is not a function. We suspect that something's messing up with jQuery but we're not entirely sure. This is a small hack to hopefully re-assign jQuery to the `$` variable. 🤞 * Update pension emails spec * Various bugfixes (#1187) * import I18n from 'champaign-i18n' (alias to window.I18n in webpack) * Deprecate legacy backbone fundraiser code. The _fundraiser_refactor.liquid partial has been deleted and its contents are now in _fundraiser.liquid. All templates that referenced 'Fundraiser Refactor' must be updated to include 'Fundraiser'. * Add global locale data in member_facing.js Instead of doing this in ComponentWrapper, add it immediately in member_facing.js * Removed unused lines * Don't attempt to assign petitionForm to jXHR response if it's a string * Redo: "Release (#1188)" This reverts commit 40ba347. * Set user context in sentry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.