Protects call tool with recaptcha #1502
Conversation
osahyoun
force-pushed
the
feature.call_tool_recapt
branch
from
1fbad54
to
90f81f6
Compare
| @@ -4,12 +4,23 @@ class Api::CallsController < ApplicationController | |||
| skip_before_action :verify_authenticity_token, raise: false | |||
|
|
|||
| def create | |||
| service = CallCreator.new(call_params, tracking_params) | |||
| success = verify_recaptcha(action: params[:recaptcha_action], minimum_score: 0.5) | |||
There was a problem hiding this comment.
Perhaps having the recaptcha gem now makes app/services/recaptcha3.rb redundant?
There was a problem hiding this comment.
@shivashankar-f22labs ☝️ fyi
There was a problem hiding this comment.
I'm proposing it as an alternative to our own implementation - it would mean less code for us to maintain.
There was a problem hiding this comment.
@osahyoun @eyko
Code what we have now is very simple. just 75 lines of code only.
Second, we need bit customisation as well.
We need to log the response for tracking the score as we have no way for that so far.
Third, we need to raise exception especially to Raven / slack when score is less than 0.5 for quickly monitoring the failed transaction with score
For these reasons I like existing recaptcha3 itself.
We shall have both for now.
osahyoun
changed the title
|
@shivashankar-f22labs care to have a look before I merge? |
No description provided.