This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Added option to exclude shares from cloning #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osahyoun
reviewed
Sep 16, 2019
spec/rails_helper.rb
Outdated
| @@ -97,4 +97,7 @@ | |||
| config.append_after(:each) do | |||
| DatabaseCleaner.clean | |||
| end | |||
|
|
|||
| config.filter_run focus: true | |||
| config.run_all_when_everything_filtered = true | |||
There was a problem hiding this comment.
Already defined in spec_helper.rb
https://github.com/SumOfUs/Champaign/blob/development/spec/spec_helper.rb#L35-L43
There was a problem hiding this comment.
ok. I will remove that one
osahyoun
reviewed
Sep 16, 2019
spec/services/page_cloner_spec.rb
Outdated
|
|
||
| context 'excluding shares from clone' do | ||
| before do | ||
| @exclude_shares = true |
There was a problem hiding this comment.
@exclude_shares isn't being used.
|
Just a couple of comments, otherwise 💯 |
osahyoun
approved these changes
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.