This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Use model scopes and jbuilder #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion with 200 if requested with a language that isn't supported. Also use the language scope on the page model.
| let!(:last_featured_page) { create :page, title: 'I am the latest featured page', featured: true, slug: 'garden_slug' } | ||
| let!(:last_mvp_page) { create :page, title: 'I am the latest test page', featured: false} | ||
| let!(:featured_pages) { create_list :page, 50, featured: true } | ||
| let!(:mvp_pages) { create_list :page, 50, featured: false } |
There was a problem hiding this comment.
Creating 100 records is a bit much. For the integration specs it would be more valuable just checking that a request is met with a json response, and that the response has certain fields present.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use language and featured scopes in the model instead of additional methods in the controller. Use jbuilder for rendering json responses from the pages api.