Add ability to archive pages #588
Conversation
|
Nice! Let's make sure this gets tested by Eoin once it's on staging from a UI perspective. |
|
UI/UX is definitely something to consider, I'm not super happy about how it works. |
| @@ -40,7 +40,7 @@ const setupOnce = require('setup_once'); | |||
| }, | |||
|
|
|||
| toggleState: function(){ | |||
| this.state = !this.state; | |||
| this.state = this.state === 'published' ? 'unpublished' : 'published'; | |||
There was a problem hiding this comment.
using 'published' and 'unpublished' instead of booleans seems like a good change
|
@rodrei a lovely PR! When clicking 'Archive', could you have the user confirm the action? It's especially important when the page is published. |
|
@osahyoun thanks! That's the cutest thing I've ever seen said about a PR ^_^ Great idea about adding a confirm. I'll add that asap. |
* Refactored Page#active boolean flag to be a Page#publish_status, which is an enum with 3 possible statuses. * Add ability to archive and unarchive pages. * Add ability to search pages filtering by `publish_status
|
@omar already added the confirm pop-up to the archive link. I also fixed an issue with the schema not being updated (that's why the tests failed previously). Lemme know if you'd like me to merge this into dev. |
|
🎆 |
which is an enum with 3 possible statuses.
publish_statusImportant: There's a new migration that includes a mini-script to update all existing pages. This is quite critical, so I urge anyone reviewing this to pay special attention to it.