Phone field fixes

[NealJMD]

@edubsky has been working with phone numbers and turned up two important bugs that I worked on today -

• Our member record was only updated with the fields that we'd defined as columns in the member table. That didn't include phone, so it meant that any form that had phone would never have that field prefilled. Rather than just add another column to the table, I added a catchall jsonb column that stores any AK-valid field so this never happens again.
• Our QueuePusher pushed only a subset of valid user fields to AK for donations (petitions were doing fine) so phone numbers were not getting pushed to AK.

These are both fixed. After we deploy, I'm inclined to run something like this to bring the current member records up to speed -

    Members.all.include(:actions).each do |m|
      params = m.actions.map(&:form_data).reduce({}, :merge)
      MemberUpdater.run(m, params)
    end

[osahyoun]

You can call column_names on the class:

Member.column_names.map(&:to_sym)[1..-1]

[osahyoun]

If you're worried name isn't a string, then perhaps call to_s on it here, rather than below? https://github.com/SumOfUs/Champaign/pull/853/files#diff-e52e089e43530d3d8f597e45e9128cfcR106

[osahyoun]

Is present? necessary? nil is falsy after all. If a boolean is a must then !(@name !~ VALID_PREFIX_RE) is more expressive, in my opinion.

[NealJMD]

I'm taking your other suggestions, but not this one - !(@name !~ VALID_PREFIX_RE) is super arcane to me, as I've never seen !~ before and it never occurs in our codebase, whereas =~ is very common. I also think that methods beginning in is_ or has_ should return booleans.

[osahyoun]

A very fine PR 💯. Merge with extreme prejudice, but not before responding to my comments!

[osahyoun]

Your suggested data migration above would bring the site to its knees. Think about using find_each instead of all

http://apidock.com/rails/ActiveRecord/Batches/find_each