Added currency field to braintree subscriptions

SumOfUs · Jan 10, 2018 · 91e19af · 91e19af
1 parent 44f5410
commit 91e19af
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/.env.test b/.env.test
@@ -7,3 +7,4 @@ export BRAINTREE_ENV=Sandbox
 export VCR_MODE=playback
 export CHAMPAIGN_URL='https://action-staging.sumofus.org'
 export UNSUBSCRIBE_PAGE_NAME=unsubscribe
+export BRAINTREE_MERCHANT_CURRENCIES="{\"EUR\": \"EUR\", \"USD\": \"USD\"}"
diff --git a/lib/clients/braintree/braintree.js b/lib/clients/braintree/braintree.js
@@ -22,7 +22,6 @@ const SUBSCRIPTION_FIELDS = [
   'failureCount',
   'firstBillingDate',
   'id',
-  'merchantAccountId',
   'nextBillingDate',
   'nextBillingPeriodAmount',
   'numberOfBillingCycles',
@@ -38,6 +37,11 @@ const TRANSACTION_FIELDS = [
   'refundedTransactionId',
 ];
 
+// Object of format: { 'merchantId': 'Currency'}, ie { souUSD: 'USD' }
+const merchantCurrencies = JSON.parse(
+  process.env.BRAINTREE_MERCHANT_CURRENCIES || '{}'
+);
+
 export const client = braintree.connect({
   environment: braintree.Environment[process.env.BRAINTREE_ENV],
   merchantId: process.env.BRAINTREE_MERCHANT_ID,
@@ -113,6 +117,8 @@ const buildSubscription = btSubscription => {
   const subscription = pick(btSubscription, SUBSCRIPTION_FIELDS);
   subscription.amount = parseFloat(btSubscription.price);
   subscription.status = btSubscription.status.toLowerCase();
+  subscription.currency =
+    merchantCurrencies[btSubscription.merchantAccountId] || 'Unknown';
 
   subscription.statusHistory = map(btSubscription.statusHistory, status => {
     return pick(status, 'status', 'balance', 'price');

diff --git a/lib/clients/braintree/braintree.test.js b/lib/clients/braintree/braintree.test.js
@@ -64,7 +64,7 @@ describe('searchCustomer', () => {
             failureCount: 0,
             firstBillingDate: '2017-11-23',
             id: 'j4ym6w',
-            merchantAccountId: 'USD',
+            currency: 'USD',
             nextBillingDate: '2017-12-23',
             nextBillingPeriodAmount: '1.00',
             numberOfBillingCycles: null,

diff --git a/settings/production.yml b/settings/production.yml
@@ -12,3 +12,4 @@ environment:
   MEMBER_SERVICES_SECRET: ${env:MEMBER_SERVICES_SECRET}
   DB_LOG_TABLE: ${env:DB_LOG_TABLE}
   UNSUBSCRIBE_PAGE_NAME: ${env:UNSUBSCRIBE_PAGE_NAME}
+  BRAINTREE_MERCHANT_CURRENCIES: ${env:BRAINTREE_MERCHANT_CURRENCIES}
diff --git a/settings/staging.yml b/settings/staging.yml
@@ -12,3 +12,4 @@ environment:
   MEMBER_SERVICES_SECRET: ${env:MEMBER_SERVICES_SECRET}
   DB_LOG_TABLE: ${env:DB_LOG_TABLE}
   UNSUBSCRIBE_PAGE_NAME: ${env:UNSUBSCRIBE_PAGE_NAME}
+  BRAINTREE_MERCHANT_CURRENCIES: ${env:BRAINTREE_MERCHANT_CURRENCIES}