Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subject access requests #23

Merged
merged 13 commits into from
Oct 25, 2018
Merged

Subject access requests #23

merged 13 commits into from
Oct 25, 2018

Conversation

Tuuleh
Copy link
Contributor

@Tuuleh Tuuleh commented Oct 11, 2018

Lambdas for handling subject access requests

@coveralls
Copy link

coveralls commented Oct 15, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-5.5%) to 76.909% when pulling a9f1010 on subject-access-requests into b412a5e on development.

@Tuuleh Tuuleh force-pushed the subject-access-requests branch 4 times, most recently from 640fa30 to be5211a Compare October 18, 2018 12:25
@Tuuleh Tuuleh changed the title WIP - needs specs - Subject access requests Subject access requests Oct 18, 2018
@Tuuleh
Copy link
Contributor Author

Tuuleh commented Oct 19, 2018

Coveralls is complaining about a decreased coverage. I have added tests for the code, but I'm introducing many new lines, all of which are not included or needed for specs (e.g. the AK SAR sql query files). I'm disinclined to add more tests just to keep Coveralls happy - I don't think we'd get much benefit from that.

@Tuuleh Tuuleh merged commit 6d3a118 into development Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tuuleh @coveralls