Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in "fluentd.logs.containers.*" does not roll fluentd pods #1046

Closed
beyondbill opened this issue Oct 29, 2020 · 2 comments · Fixed by #1053
Closed

Change in "fluentd.logs.containers.*" does not roll fluentd pods #1046

beyondbill opened this issue Oct 29, 2020 · 2 comments · Fixed by #1053
Milestone

Comments

@beyondbill
Copy link

beyondbill commented Oct 29, 2020

Versions

Chart: v1.3.1
Helm: v3.3.0
Kubernetes: v1.18.2

Reproduction

On an existing installation, run

helm upgrade --namespace sumologic --set fluentd.logs.containers.xxx=yyy  sumologic sumologic/sumologic

where xxx and yyy are any valid values and yyy is different than the previous value of fluentd.logs.containers.xxx

Expectation

Statefulset sumologic-sumologic-fluentd-logs should roll all its pods to take the new setting fluentd.logs.containers.xxx=yyy into effect.

Actual result

Pods in statefulset sumologic-sumologic-fluentd-logs remain unchanged. The new setting fluentd.logs.containers.xxx=yyy won't take into effect.

Analysis

Helm takes the new setting fluentd.logs.containers.xxx=yyy and update the key-value pair in configMap sumologic-sumologic-fluentd-logs. Although statefulset sumologic-sumologic-fluentd-logs has a reference to configMap sumologic-sumologic-fluentd-logs, the contents of the statefulset template does not change. Therefore the statefulset sees no change and does not roll its pods.

I have not yet come up with any fix for this. Will update the issue when I have any idea.

@beyondbill
Copy link
Author

@perk-sumo @sumo-drosiek Thanks for the quick response! The checksum annotation solution is brilliant! Looking forward to the release!

@sumo-drosiek
Copy link
Contributor

No problem 🚀

The idea comes from official helm documentation 📖
https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants