Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having traces enabled and metrics disabled still allows to send metrics via (traces) otelcol's instances #2183

Open
pmalek-sumo opened this issue Mar 15, 2022 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@pmalek-sumo
Copy link
Contributor

With introduction of this change: #1647 the chart has an option to send metrics via otelcol's pods (originally designed to handle tracing traffic).

This happens even when sumologic.metrics.enabled is set to false and sumologic.traces.enabled is set to true.

This goal of this issue is to track a set of (breaking) changes that would go into chart that would change the approach from enabling/disabling particular components (e.g. metrics pipeline, tracing pipeline etc) into enabling/disabling particular use cases (e.g. collecting metrics from kubelet, collecting metrics from instrumentations, collecting traces from apps with particular config/instrumentation etc.)

There's a PR that should resolve the problem with missing default-metrics source URL being present in the cluster when sumologic.metrics.enabled is set to false and sumologic.traces.enabled is set to true: #2182 but that will only fix the implementation bug, it won't affect the API contract within the values.yaml of this chart (e.g. sumologic.metrics.enabled=false shouldn't really send metrics).

@pmalek-sumo pmalek-sumo added the bug Something isn't working label Mar 15, 2022
@pmalek-sumo pmalek-sumo added this to the v3.0 milestone Mar 15, 2022
@perk-sumo perk-sumo modified the milestones: v3.0, v4.0 Jan 13, 2023
@perk-sumo perk-sumo modified the milestones: v4.0, v5.0 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants