Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modules and git tags so that plugins are importable #369

Closed
pmalek-sumo opened this issue Dec 20, 2021 · 0 comments · Fixed by #371 or #370
Closed

Fix modules and git tags so that plugins are importable #369

pmalek-sumo opened this issue Dec 20, 2021 · 0 comments · Fixed by #371 or #370
Assignees

Comments

@pmalek-sumo
Copy link
Contributor

We didn't really cover the use case of using our plugins externally, i.e. that wasn't tested. In order to support this we'll need to do 2 things:

  • add module directory prefixes tags as part of our release process so that users (like yourself) can pull them into the build, this is due to cmd/go: allow serving module under the subdirectory of git repository golang/go#34055 being accepted but not implemented 😞 . So in order for the above to work with our exporter's line uncommented we'd need a tag like this pkg/exporter/sumologicexporter/v0.0.43-beta.0 which could then be used like so in the builder config:

    exporters:
      - gomod: "github.com/SumoLogic/sumologic-otel-collector/pkg/exporter/sumologicexporter v0.0.43-beta.0"
    
  • point to proper versions of our internal dependencies that we rely on (e.g. extension <=> exporter), I'm talking about this line for instance

Related thread on slack: https://sumodojo.slack.com/archives/G011R8ZMUEB/p1640018349031800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant